Moves asset tests to the static build

withastro · Feb 28, 2022 · ee214d2 · ee214d2
1 parent d19a370
commit ee214d2
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 8 deletions.
diff --git a/packages/astro/test/astro-scripts.test.js b/packages/astro/test/astro-scripts.test.js
@@ -9,7 +9,11 @@ describe('Scripts (hoisted and not)', () => {
 	before(async () => {
 		fixture = await loadFixture({
 			projectRoot: './fixtures/astro-scripts/',
-			buildOptions: { legacyBuild: true } // TODO make this test work without legacyBuild
+			vite: {
+				build: {
+					assetsInlineLimit: 0
+				}
+			}
 		});
 		await fixture.build();
 	});
@@ -41,8 +45,8 @@ describe('Scripts (hoisted and not)', () => {
 		// test 2: attr removed
 		expect($('script').attr('data-astro')).to.equal(undefined);
 
-		let entryURL = path.join('inline', $('script').attr('src'));
-		let inlineEntryJS = await fixture.readFile(entryURL);
+		const entryURL =  $('script').attr('src');
+		const inlineEntryJS = await fixture.readFile(entryURL);
 
 		// test 3: the JS exists
 		expect(inlineEntryJS).to.be.ok;
@@ -56,7 +60,7 @@ describe('Scripts (hoisted and not)', () => {
 		expect($('script')).to.have.lengthOf(2);
 
 		let el = $('script').get(1);
-		let entryURL = path.join('external', $(el).attr('src'));
+		let entryURL = $(el).attr('src');
 		let externalEntryJS = await fixture.readFile(entryURL);
 
 		// test 2: the JS exists

diff --git a/packages/astro/test/fixtures/astro-scripts/src/components/NoHoistClassic.astro b/packages/astro/test/fixtures/astro-scripts/src/components/NoHoistClassic.astro
@@ -1 +1,4 @@
-<script src={Astro.resolve("../scripts/no_hoist_nonmodule.js")}></script>
+---
+import url from "../scripts/no_hoist_nonmodule.js?url"
+---
+<script src={url}></script>
diff --git a/packages/astro/test/fixtures/astro-scripts/src/components/NoHoistModule.astro b/packages/astro/test/fixtures/astro-scripts/src/components/NoHoistModule.astro
@@ -1 +1,4 @@
-<script type="module" src={Astro.resolve("../scripts/no_hoist_module.js")}></script>
+---
+import url from '../scripts/no_hoist_module.js?url';
+---
+<script type="module" src={url}></script>
diff --git a/packages/astro/test/fixtures/astro-scripts/src/components/Widget.astro b/packages/astro/test/fixtures/astro-scripts/src/components/Widget.astro
@@ -1 +1 @@
-<script hoist type="module" src={Astro.resolve("../scripts/something.js")}></script>
+<script hoist type="module" src="../scripts/something.js"></script>
diff --git a/packages/astro/test/fixtures/astro-scripts/src/components/Widget2.astro b/packages/astro/test/fixtures/astro-scripts/src/components/Widget2.astro
@@ -1 +1 @@
-<script hoist type="module" src={Astro.resolve("../scripts/another_external.js")}></script>
+<script hoist type="module" src="../scripts/another_external.js"></script>
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		<script hoist type="module" src={Astro.resolve("../scripts/something.js")}></script>
		<script hoist type="module" src="../scripts/something.js"></script>