-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(@astrojs/telemetry): add optional integrations field (#3614)
* fix: filter out falsy integration from telemetry Falsy integrations are now ignored in `@astrojs/telemetry` This error should no longer occur, ```ts error Cannot read properties of null (reading 'name') at file:///workspaces/bundle/node_modules/.pnpm/@astrojs+telemetry@0.1.2/node_modules/@astrojs/telemetry/dist/events/session.js:53:117 ... ``` * ci: add tests for optional integrations * ci: add changeset * fix(@astrojs/telemetry): count number of optional integrations in use * ci: add test for counting the total number of optional integrations in use * ci: update changeset * chore: make the changes @tony-sull sugested * revert(@astrojs/webapi): mod.d.ts -> a4c78b5: [ci] format * ci: remove `@astrojs/webapi` patch change * chore(@astrojs/telemetry): remove totalIntegrations payload field * fix(@astrojs/telemetry): add optional integrations field * ci: add changeset
- Loading branch information
Showing
4 changed files
with
63 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
'@astrojs/telemetry': patch | ||
--- | ||
|
||
Fix telemetry crashing astro build/dev when using optional integrations | ||
|
||
Telemetry will now ignore falsy integration values but will gather a count of how many integrations out of the total are now optional integrations |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@astrojs/telemetry': patch | ||
--- | ||
|
||
Add's optional integrations field to `@astrojs/telemetry`'s payload |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters