Preserve all error stack lines (#4364)

withastro · Aug 18, 2022 · 77b0680 · 77b0680
1 parent 41b81d0
commit 77b0680
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/.changeset/rare-comics-roll.md b/.changeset/rare-comics-roll.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Preserve all error stack lines
diff --git a/packages/astro/src/core/errors.ts b/packages/astro/src/core/errors.ts
@@ -37,7 +37,6 @@ export interface ErrorWithMetadata {
 export function cleanErrorStack(stack: string) {
 	return stack
 		.split(/\n/g)
-		.filter((l) => /^\s*at/.test(l))
 		.map((l) => l.replace(/\/@fs\//g, '/'))
 		.join('\n');
 }

diff --git a/packages/astro/src/core/messages.ts b/packages/astro/src/core/messages.ts
@@ -18,7 +18,7 @@ import type { AddressInfo } from 'net';
 import os from 'os';
 import { ZodError } from 'zod';
 import type { AstroConfig } from '../@types/astro';
-import { cleanErrorStack, ErrorWithMetadata } from './errors.js';
+import { ErrorWithMetadata } from './errors.js';
 import { emoji, getLocalAddress, padMultilineString } from './util.js';
 
 const PREFIX_PADDING = 6;
@@ -235,10 +235,10 @@ export function formatErrorMessage(err: ErrorWithMetadata, args: string[] = []):
 		args.push(red(padMultilineString(err.frame, 4)));
 	}
 	if (args.length === 1 && err.stack) {
-		args.push(dim(cleanErrorStack(err.stack)));
+		args.push(dim(err.stack));
 	} else if (err.stack) {
 		args.push(`  ${bold('Stacktrace:')}`);
-		args.push(dim(cleanErrorStack(err.stack)));
+		args.push(dim(err.stack));
 		args.push(``);
 	}
 	return args.join('\n');