Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data sources #386

Closed
wants to merge 1 commit into from
Closed

Update data sources #386

wants to merge 1 commit into from

Conversation

aleksa-codes
Copy link

@aleksa-codes aleksa-codes commented Nov 2, 2022

Some of the links on the Integrations page were linking back to https://astro.build, changed them to lead to a reference in the doc (for prism and markdown-component) and GitHub readme (for agnosticui-astro).

Prism and legacy markdown-component are mentioned in multiple places, so I tried to pick the reference that gives the most useful information about them.

@netlify
Copy link

netlify bot commented Nov 2, 2022

Deploy Preview for astro-www-2 ready!

Name Link
🔨 Latest commit 9d8eaaa
🔍 Latest deploy log https://app.netlify.com/sites/astro-www-2/deploys/63626579dd1bd9000955dcef
😎 Deploy Preview https://deploy-preview-386--astro-www-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aleksa-codes aleksa-codes changed the title Update data source Update data sources Nov 2, 2022
@delucis
Copy link
Member

delucis commented Nov 2, 2022

Thank you @aleksa-codes! Unfortunately this data is automatically scraped every night, so your manual changes will be overwritten next time that runs.

Instead we will need to update the URLs in each integration’s package.json file in https://github.com/withastro/astro

Would you be up for that?

@aleksa-codes
Copy link
Author

Thank you @aleksa-codes! Unfortunately this data is automatically scraped every night, so your manual changes will be overwritten next time that runs.

Instead we will need to update the URLs in each integration’s package.json file in https://github.com/withastro/astro

Would you be up for that?

@delucis My bad, I thought it was only for the repo stars. I will gladly do that! Have you maybe checked the links I added? Just to clarify if chose good ones, thank you.

@aleksa-codes
Copy link
Author

aleksa-codes commented Nov 2, 2022

I've made pull request hopefully it gets approved, thank you! Though I haven't found where the link for agnosticui-astro is coming from.

@delucis
Copy link
Member

delucis commented Nov 2, 2022

Thanks! agnosticui-astro is a third-party package, so would need updating there. I think this is the relevant package.json on GitHub, but don’t know if they’re accepting PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants