-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve _routes.json generation #423
Merged
alexanderniebuhr
merged 5 commits into
withastro:main
from
schummar:feature/better-routes-json-for-many-static-files
Oct 21, 2024
Merged
feat: improve _routes.json generation #423
alexanderniebuhr
merged 5 commits into
withastro:main
from
schummar:feature/better-routes-json-for-many-static-files
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e843967 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
alexanderniebuhr
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to make sense to me.
alexanderniebuhr
changed the title
feat: better _routes.json for many static files
feat: improve _routes.json generation
Oct 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a result of the discussion in #374. I found a quick win that makes things a lot better without additional risk. More could be done to generate smaller, correct solutions for even more cases - but as a first step I'm pretty happy with this.
Problem: When there are a lot of static pages (resulting in more than 100 combined include/exclude entries, the adapter would generate a _routes.json with a
/*
include and a truncated array of excludes. Even if having a fewincludes
and noexcludes
instead would be a correct solution too - with the added benefit of no unnecessary function invocations.Solution: I improved the condition which switches between the two options (option 1 =
/*
include + many excludes; option 2 = many includes, fewer excludes). Now option 2 is chosen if: there is a static 404 AND option 2 is below the limit.Testing
I added two test cases with many static files. One with and one without a static 404 file.
Docs
Not sure if anything needs to be documented.