-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added windows support for static files #387
Conversation
🦋 Changeset detectedLatest commit: b6574c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for tests, but lgtm
@alexanderniebuhr fixed the formatting and linting error. PR should be good to go now. |
Do you have a repro or test for this? Checking the Astro source code, I don't think a backslash could happen in the first place. It'd be a bug there. |
@bluwy Here is a minimal reproduction of the issue. Just installed asto (latest version) and the astro cloudflare plugin. When I add folders in the public folder and run |
With your adjusted code, it makes more sense now and I think that's the right fix. Initially you made the change for Astro's |
@veitbjarsch can you add an changeset with |
@alexanderniebuhr done |
Changes
On windows machines it did not split up the path for static files into it's parts, because it was only searching for posix separators.
Testing
Run the build on windows machines an check the _routes.json before and after.
Docs