New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] set Background color in Connector and Wire Box #210

Closed

designer2k2 opened this issue Jan 9, 2021 · 2 comments

Milestone

designer2k2 commented Jan 9, 2021

Hello,
let me first thank you for WireViz, it helps me keeping the wires in my car sorted and documented.

With larger projects the output gets a bit difficult to grasp, as everything is white.

How about an option to set the background-color from either the entire box, or the topmost box?

An example:

Manually edited in the svg:

If the entire box or the topmost im not shure, maybe the entire box can be a bit too much.

It would be nice if i can define this in the yml file, maybe as optional "bgcolor" that is passed to graphviz.

Anyway, thanks for WireViz!

kvid added a commit to kvid/WireViz that referenced this issue


          Add bgcolor attribute to connectors and cables

13f0bac

This solves the wireviz#210 suggestion to render the top/title row of
the graph nodes with this bgcolor.

kvid mentioned this issue

Add bgcolor attribute to connectors and cables #219

Merged

kvid added a commit to kvid/WireViz that referenced this issue


          Add bgcolor attribute to connectors and cables

e06f663

This solves the wireviz#210 suggestion to render the title row of
the graph nodes with this bgcolor.

kvid added a commit to kvid/WireViz that referenced this issue


          Support both bgcolor and bgcolor_title attributes

5673ee4

Solves wireviz#210 completely by supporting bgcolor of both the node title
and the whole node independently using separate attributes.

Collaborator

kvid commented Feb 20, 2021

@designer2k2 and others that might need this feature are invited to clone my branch in PR #219, test this feature, and then make a review or some other comment about the suggested implementation.

Author

designer2k2 commented Mar 9, 2021 •

edited

Loading

thanks @kvid for #219, this solves my feature request 😀

I tested #219 and it works here for me as expected

kvid added a commit to kvid/WireViz that referenced this issue


          Add bgcolor attribute to connectors and cables

245258f

This solves the wireviz#210 suggestion to render the title row of
the graph nodes with this bgcolor.

kvid added a commit to kvid/WireViz that referenced this issue


          Support both bgcolor and bgcolor_title attributes

416faf3

Solves wireviz#210 completely by supporting bgcolor of both the node title
and the whole node independently using separate attributes.

kvid added a commit to kvid/WireViz that referenced this issue


          Add bgcolor attribute to connectors and cables

eac940e

This solves the wireviz#210 suggestion to render the title row of
the graph nodes with this bgcolor.

kvid added a commit to kvid/WireViz that referenced this issue


          Support both bgcolor and bgcolor_title attributes

e0a177a

Solves wireviz#210 completely by supporting bgcolor of both the node title
and the whole node independently using separate attributes.

kvid added a commit to kvid/WireViz that referenced this issue


          Add bgcolor attribute to connectors and cables

c2cc851

This solves the wireviz#210 suggestion to render the title row of
the graph nodes with this bgcolor.

kvid added a commit to kvid/WireViz that referenced this issue


          Support both bgcolor and bgcolor_title attributes

b465131

Solves wireviz#210 completely by supporting bgcolor of both the node title
and the whole node independently using separate attributes.

17o2 added this to the v0.3 milestone

kvid added a commit to kvid/WireViz that referenced this issue


          Add bgcolor attribute to connectors and cables

52d6d3c

This solves the wireviz#210 suggestion to render the title row of
the graph nodes with this bgcolor.

kvid added a commit to kvid/WireViz that referenced this issue


          Support both bgcolor and bgcolor_title attributes

15e5189

Solves wireviz#210 completely by supporting bgcolor of both the node title
and the whole node independently using separate attributes.

17o2 pushed a commit that referenced this issue


          Add bgcolor attribute to connectors and cables

dbccb77

This solves the #210 suggestion to render the title row of
the graph nodes with this bgcolor.

17o2 pushed a commit that referenced this issue


          Support both bgcolor and bgcolor_title attributes

45d7d03

Solves #210 completely by supporting bgcolor of both the node title
and the whole node independently using separate attributes.

17o2 closed this as completed

17o2 added a commit that referenced this issue


          Add #210, #219

aaf2299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment