Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method selection data may be irregular, incompatible with 3proxy #27

Closed
ge9 opened this issue Mar 19, 2024 · 0 comments
Closed

method selection data may be irregular, incompatible with 3proxy #27

ge9 opened this issue Mar 19, 2024 · 0 comments

Comments

@ge9
Copy link

ge9 commented Mar 19, 2024

Hi, thank you for this great software.

I had a problem (connection is reset) in using proxifyre with SOCKS5 server 3proxy (https://3proxy.ru/), and I figured out that the problem lies in method selection.

Even when no password is specified, Proxifyre sends the following method selection data:

05 02 00 02

This means, 05 (SOCKS v5), 02 (two methods are available), 00 (first method: no auth), 02 (second method: password auth)
3proxy seems to prefer password auth than no auth (https://github.com/3proxy/3proxy/blob/29ef226b3cbdc2f1cefd8d6d54387bcd67a38384/src/socks.c#L63) and requests password, resulting in authentication failure and connection being reset.

Proxifyre still works with other SOCKS5 proxy that prefers no auth to password auth, but I guess Proxifyre is responsible for this problem.

Specifically, when no password is specified, Proxifyre should send the following method selection data:

05 01 00
wiresock added a commit that referenced this issue May 18, 2024
Resolved the issue where Proxifyre sends both "no auth" and "password auth" methods, causing connection resets with 3proxy. Now, when no username is specified, Proxifyre sends only the "no auth" method. This ensures compatibility with 3proxy and prevents authentication failures.
@ge9 ge9 closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant