Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModuleNotFoundError: No module named 'attr' #339

Closed
7 tasks done
bourbonkk opened this issue Sep 25, 2023 · 2 comments
Closed
7 tasks done

ModuleNotFoundError: No module named 'attr' #339

bourbonkk opened this issue Sep 25, 2023 · 2 comments

Comments

@bourbonkk
Copy link

bourbonkk commented Sep 25, 2023

Issues

GitHub issues are for bugs. If you have questions, please ask them on stackoverflow.
attr dependency is missing in 3.0.0 version

Checklist

  • Does your title concisely summarize the problem?
  • Did you include a minimal, reproducible example?
  • What OS are you using?
  • What version of Remoulade are you using?
  • What did you do?
  • What did you expect would happen?
  • What happened?

What OS are you using?

ubuntu 20.04

What version of Remoulade are you using?

3.0.0

Successfully built opentelemetry-instrumentation-remoulade
Installing collected packages: pytz, six, prometheus-client, python-dateutil, remoulade, opentelemetry-instrumentation-remoulade
Successfully installed opentelemetry-instrumentation-remoulade-0.42b0.dev0 prometheus-client-0.17.1 python-dateutil-2.8.2 pytz-2023.3.post1 remoulade-3.0.0 six-1.16.0

What did you do?

Running test code (https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/instrumentation/opentelemetry-instrumentation-remoulade/tests/test_messages.py)

What did you expect would happen?

Running test code successfully

What happened?

ModuleNotFoundError

_ ERROR collecting instrumentation/opentelemetry-instrumentation-remoulade/tests/test_messages.py _
ImportError while importing test module '/home/runner/work/opentelemetry-python-contrib/opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-remoulade/tests/test_messages.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
test_messages.py:15: in <module>
    import remoulade
../../../.tox/py38-test-instrumentation-remoulade/lib/python3.8/site-packages/remoulade/__init__.py:18: in <module>
    from .actor import Actor, actor
../../../.tox/py38-test-instrumentation-remoulade/lib/python3.8/site-packages/remoulade/actor.py:23: in <module>
    from .helpers.actor_arguments import get_actor_arguments
../../../.tox/py38-test-instrumentation-remoulade/lib/python3.8/site-packages/remoulade/helpers/__init__.py:20: in <module>
    from .reduce import reduce
../../../.tox/py38-test-instrumentation-remoulade/lib/python3.8/site-packages/remoulade/helpers/reduce.py:17: in <module>
    from ..composition import group
../../../.tox/py38-test-instrumentation-remoulade/lib/python3.8/site-packages/remoulade/composition.py:26: in <module>
    from .collection_results import CollectionResults
../../../.tox/py38-test-instrumentation-remoulade/lib/python3.8/site-packages/remoulade/collection_results.py:28: in <module>
    from .result import Result
../../../.tox/py38-test-instrumentation-remoulade/lib/python3.8/site-packages/remoulade/result.py:20: in <module>
    import attr
E   ModuleNotFoundError: No module named 'attr'
@mehdigmira
Copy link

Oh, this went undetected in the CI because attrs is a dependency of flake8-bugbear which is itself a dev dependency of remoulade.
Sorry for this, will be fixed soon. Meanwhile, you can add attrs dependency on your project as a workaround.

@antoinerabany
Copy link
Member

fixed in 3.0.1

bourbonkk added a commit to bourbonkk/opentelemetry-python-contrib that referenced this issue Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants