Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Class "Cms\Classes\Log" not found error #858

Merged
merged 2 commits into from
Mar 5, 2023
Merged

Fix Class "Cms\Classes\Log" not found error #858

merged 2 commits into from
Mar 5, 2023

Conversation

xitara
Copy link
Contributor

@xitara xitara commented Mar 5, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Mar 5, 2023

  • The log class was changed from Log to \Log

@bennothommo
Copy link
Member

@xitara the convention would be to include a use Log; call at the top of the file where the other use cases are. Would you mind changing the change to that? I will then merge it.

@bennothommo bennothommo added maintenance PRs that fix bugs, are translation changes or make only minor changes Status: Revision Needed labels Mar 5, 2023
@bennothommo bennothommo added this to the v1.2.2 milestone Mar 5, 2023
@xitara
Copy link
Contributor Author

xitara commented Mar 5, 2023

no problem :)

@bennothommo bennothommo merged commit 5d07e65 into wintercms:develop Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Milestone
v1.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@xitara @bennothommo @LukeTowers