-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backend calendar controller #1313
base: wip/calendar-widget
Are you sure you want to change the base?
Conversation
-add widget initial view config -add widget first day of week config -add model attribute config for all day event
$this->recordEnd, | ||
]; | ||
|
||
// $this->validateModel(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to add it based on the ListController but I get an error.
Need to take a closer look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LukeTowers If I try to validate the model (as in Lists widget), then this error in throw :
Typed property Backend\Widgets\Calendar::$model must not be accessed before initialization
.
Same if I try to add model
to the fillFromConfig()
method in plugin initialization.
@damsfx can you take a stab at pulling and compiling the assets with vite so that they're pulled in with package.json rather than including the vendor assets in the code directly? We're trying to move away from including the raw vendor assets as the source of truth (although we'd still be committing the compiled results and including those), it's mostly just to make it easier to update the dependencies in the future. Let me know if you need any help with that. |
I wouldn't mind a little help on this one. |
- add calendar less file to ServiceProvider - use fullcalendar css variables for theming - add option to chosse calendar theme for buttons style base on Winter's ones
Original PR #970
FullCalendar docs
CalendarController