Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Add testing spec skeleton #2

Closed

Conversation

UlisesGascon
Copy link

@UlisesGascon UlisesGascon commented May 9, 2023

Main changes

  • Added basic support for Node.js App (testing, linting, nvm...)
  • Added basic pipeline to review PRs
  • Added sample spec for documentation and tests using JSON schema and Jest
  • Added basic documentation

Context

This skeleton is based on POC-semver-and-json-schemas

Changelog

@UlisesGascon UlisesGascon marked this pull request as ready for review May 9, 2023 21:28
Co-authored-by: Steven <steven@ceriously.com>

Details:
- The `name` is an optional property.
- The `name` must be less than or equal to 214 characters.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the existing npm docs can be copied as a starting point.

https://docs.npmjs.com/cli/v9/configuring-npm/package-json

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I was using part of it as a reference. I can port the docs easily if we agreed on it at #1 (comment) in a separate PR 😄

@UlisesGascon UlisesGascon mentioned this pull request May 10, 2023
@wesleytodd
Copy link

wesleytodd commented May 10, 2023

I think this PR should not land as is, and I honestly think the presence of this already here is jumping the gun. @UlisesGascon I am super happy to see your excitement, but I am worried that jumping right into implementation might cause legal or process issues for the effort. I think a better way to approach this would be to propose a set of things you would like to PR in an issue and then as this effort gets off the ground we can discuss and make sure we are not introducing any IP restrictions which would block this getting actual standards bodies involved.

@UlisesGascon
Copy link
Author

Thanks for the advice @wesleytodd 😉. I will close the PR for now until we are clear on how to move forward

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants