Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting logger instance from container when closing logger with instance method #532

Closed
wants to merge 1 commit into from
Closed

Deleting logger instance from container when closing logger with instance method #532

wants to merge 1 commit into from

Conversation

mykolaharmash
Copy link
Contributor

No description provided.

@indexzero
Copy link
Member

lgtm. Breaking change to that semantic. Will go into 1.0.0 release (should ship by late Feb).

@indexzero indexzero added Feature Request Request for new functionality to support use cases not already covered breaking labels Jan 29, 2015
@mykolaharmash
Copy link
Contributor Author

Great, thanks!

@indexzero
Copy link
Member

Thanks! Cherry-picked. Will go into winston@1.0.0 which will be published shortly.

@indexzero indexzero closed this Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking Feature Request Request for new functionality to support use cases not already covered
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mykolaharmash @indexzero