Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LogCallback in ts definition files #2513

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Conversation

tokidoki11
Copy link
Contributor

Background

LogCallback is not supported anymore as per version 3 and can cause confusion

https://github.com/winstonjs/winston/blob/HEAD/UPGRADE-3.0.md#winstonlogger
winston.Logger.log and level-specific methods (.info, .error, etc) no longer accepts a callback.

This PR removes the LogCallback types and its reference in LogLevelMethod and LogMethod interface

closes: #1922

Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem fine per the issue linked in the PR description, but see the discussion in that issue - need to figure out if this goes in a major or minor release. A bit hesitant to do a major release for some TS changes, but perhaps it's ok to do this as a minor release if these TS definitions never worked?

@DABH DABH merged commit 3a54777 into winstonjs:master Oct 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS definition: incorrect signatures with callback argument
2 participants