Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixes from #1355 to unhandled rejection handler as well #1555

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Add fixes from #1355 to unhandled rejection handler as well #1555

merged 1 commit into from
Jan 2, 2019

Conversation

DABH
Copy link
Contributor

@DABH DABH commented Dec 26, 2018 •
edited
Loading

The same fixes for the exception handler should be applied to the unhandled rejection handler.

@DABH DABH requested a review from indexzero December 26, 2018 21:44
@DABH DABH merged commit abac7e2 into master Jan 2, 2019
@DABH DABH mentioned this pull request Jan 3, 2019
Closed
@indexzero indexzero deleted the patch-rejection-handler branch January 4, 2019 21:19
Mizumaki pushed a commit to Mizumaki/winston that referenced this pull request Jun 11, 2020
@DABH
Add fixes from winstonjs#1355 to unhandled rejection handler as well (w…
61f1048 
…instonjs#1555)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indexzero indexzero Awaiting requested review from indexzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DABH