Consistent handling of meta with (and without) interpolation in winston & logform #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DABH
approved these changes
Dec 23, 2018
Closed
2 tasks
Mizumaki
pushed a commit
to Mizumaki/winston
that referenced
this pull request
Jun 11, 2020
…on & logform (winstonjs#1552) * [doc fix] Build on the work from winstonjs#1485 fixes. * [tiny] Formatting changes. * [fix test] Updated tests to latest (consistent) semantics. * [dist] Update to `logform@2.0.0` and `winston-transport@4.3.0`. * [doc] Document all possible permuations for splat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the
logform@2.0.0CHANGELOG for more details. TL;DR? Handling of "meta" is now consistent betweenlogformandwinstonmeaning that anymeta(i.e. additionalSPLATparameters beyond the number of string interpolation tokens in themessageprovided) will beObject.assigninto theinfocreated by.log.Related: #1485, #1499, winstonjs/logform#57, winstonjs/logform#67