Check log.length when evaluating "legacyness" of transports #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen attempting to wrap in a LegacyTransportStream.
mattberther
approved these changes
May 30, 2018
Merged
Mizumaki
pushed a commit
to Mizumaki/winston
that referenced
this pull request
Jun 11, 2020
…s#1340) * [test] Add failing test for peerDependency inheritance concerns. * [fix test] Ensure that inheritance side-effects are properly caught when attempting to wrap in a LegacyTransportStream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
winston@3this code inle_nodewould not result in theLogentriesTransportbeing wrapped in aLegacyTransportStreambecausewinston.Transportwill berequire('winston-transport')and notrequire('winston-compat').Transportas we expect.To work around this we now also check the function
lengthof thelogfunction to ensure a length of two. This is not a perfect check, but it should handle the 80% case.Related: #1280, winstonjs/winston-transport#23