Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Bind this context for _onDrain and _onError methods #1104

Merged
merged 2 commits into from
Oct 19, 2017

Conversation

mempf
Copy link
Contributor

@mempf mempf commented Oct 16, 2017

Binds the this context for _onDrain and _onError methods in the File
transport to allow access to the this._next and this._drains properties.

See issue #1102 for more information

Josh added 2 commits October 15, 2017 23:19
Binds the this context for _onDrain and _onError methods in the File
transport to allow access to the this._next and this._drains properties.

See issue winstonjs#1102 for more information
This method prevents the functions from being rebound everytime it's
called.
@jcrugzz
Copy link
Contributor

jcrugzz commented Oct 19, 2017

@mempf thanks for this!

@jcrugzz jcrugzz merged commit 19f170a into winstonjs:master Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants