Use fast-safe-stringify for perf and to support circular refs #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While catching up with @davidmarkclements at JSConf I was reminding that
fast-safe-stringify
is a great piece of code we should use by default. This PR:fast-safe-stringify
instead ofJSON.stringify
fast-safe-stringify
also supports circular JSON refs 🎉writeable
towritable
within internal test code to be consistent with Node core naming conventions.I tip my hat to @davidmarkclements here for doing all the heavy lifting:
Before
After
That's almost a 20% gain on that benchmark. 💯