Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GLib scripts when Python path contains spaces #1474

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Nov 10, 2024

@danyeaw danyeaw requested a review from nacho November 10, 2024 03:06
@nacho
Copy link
Contributor

nacho commented Nov 11, 2024

@danyeaw not clear to me from the comments in the issue. Shall we wait to have an agreement or do you still want to ship this?

@danyeaw
Copy link
Member Author

danyeaw commented Nov 11, 2024

Hi @nacho, I updated https://gitlab.gnome.org/GNOME/glib/-/issues/3331 with a new proposal based on a lot of feedback I received on my merge request. I would appreciate your feedback as well. Thanks!

@danyeaw
Copy link
Member Author

danyeaw commented Nov 25, 2024

Hi @nacho, I think the right solution is for upstream to create a new meson option, however, it doesn't seem like we have consensus yet. Should we merge some type of fix in the meantime?

@nacho
Copy link
Contributor

nacho commented Nov 25, 2024

Sure, go ahead

@danyeaw
Copy link
Member Author

danyeaw commented Nov 26, 2024

@nacho, thanks, could you give the PR an approval please?

@danyeaw danyeaw merged commit d70c4cf into main Dec 16, 2024
8 checks passed
@danyeaw danyeaw deleted the glib-fix-shebang branch December 16, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gdk-pixbuf fails to compile in CI
2 participants