-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTK 4.14.3 and other updates #1320
Conversation
gvsbuild/projects/opus.py
Outdated
@@ -24,10 +24,10 @@ def __init__(self): | |||
CmakeProject.__init__( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we switch back to meson? as far as I can see they merged the fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea @pbor!
gvsbuild/projects/opus.py
Outdated
use_ninja=True, | ||
cmake_params="-DOPUS_BUILD_SHARED_LIBRARY=ON -DOPUS_BUILD_TESTING=OFF", | ||
) | ||
Meson.build(self) | ||
self.install(r"COPYING share\doc\opus") | ||
|
||
configuration = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This chunk needs to be removed as well I think. It was added in 8d5e456
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pbor, good catch!
68067ed
to
5b03bd1
Compare
No description provided.