Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTK 4.14.3 and other updates #1320

Merged
merged 7 commits into from
Apr 26, 2024
Merged

GTK 4.14.3 and other updates #1320

merged 7 commits into from
Apr 26, 2024

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Apr 20, 2024

No description provided.

@@ -24,10 +24,10 @@ def __init__(self):
CmakeProject.__init__(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we switch back to meson? as far as I can see they merged the fixes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea @pbor!

use_ninja=True,
cmake_params="-DOPUS_BUILD_SHARED_LIBRARY=ON -DOPUS_BUILD_TESTING=OFF",
)
Meson.build(self)
self.install(r"COPYING share\doc\opus")

configuration = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This chunk needs to be removed as well I think. It was added in 8d5e456

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pbor, good catch!

@danyeaw danyeaw force-pushed the weekly-update-2024.4.18 branch from 68067ed to 5b03bd1 Compare April 25, 2024 21:54
@pbor pbor merged commit 99f9cbe into main Apr 26, 2024
12 checks passed
@pbor pbor deleted the weekly-update-2024.4.18 branch April 26, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants