feat(compiler): bring local wing files #252

3p3r · 2022-10-11T19:29:35Z

This PR does a re-implementation of my previous PR to bring local Wing files.
context: #208

behavior of circular imports and re-importing the same files needs deeper discussion, currently it blindly emits empty statements if it encounters a circular import.
investigate merge of Use and Bring statements at AST level (parser.rs).
instead of emitting empty statements, build_statement should return an Option or maybe an EmptyStatement in AST.
tests for the circular bring behavior whenever it's decided and finalized.

Huge props to @yoav-steinberg for the pairing session.

Merge jsii resource clients into generate wing resources. Handle JSII Void return types as no return type in wing.

* Added support fro `struct`s in parser/type_checker/jsification. * Import constructors (including skipping scope/id on resources). * Pass "self" argument to imported class methods.

* refactor: moved jsii importing logic into submodule under a new type_check module. * resolve namespaced custom types in type checker. * corretly handle parent resource in resource type checking. * JSII imported handles references to other JSII types (not only primitives).

* Also added support for multiple struct inheritance in when importing JSII props. * Support importing wingsdk `Duration` types.

also: Cleaned up method_call vs function_call in grammar/ast Fixed return type parsing

* Updated sdk_capture tests to use explicit Props ars used by sdk resources. * Support type annotation in container literals. * Added map literals support. * de-dup captured method names in capture mechanism. * removed auto capturing of everything looking like a mehtod call on an anything object (AKA wingsdk support hack).

Co-authored-by: Chris Rybicki <chrisr@monada.co>

3p3r · 2022-10-11T19:39:56Z

This needs to be merged after #242 is merged. It's branched off Yoav's branch.

Also: * Fix inflight.w example based on real imported cloud.Bucket type. * Removed skipping type checking on `new` expressions when the type is resolved to an `Anything`, we don't expect custom types to be `Anything`'s anymore.

This was there because we didn't really know the type of the `new` expression. Now the type is available through a the `Expr.evaluated_type`.

Co-authored-by: Elad Ben-Israel <elad.benisrael@gmail.com>

libs/wingc/src/capture.rs

libs/wingc/src/jsiiify.rs

…ep/wing_import

libs/wingc/src/parser/bring.rs

staycoolcall911 · 2022-10-26T07:13:37Z

Hey @3p3r, what's the status of this? Can it be merged to main?

3p3r · 2022-10-26T16:08:50Z

@staycoolcall911 this looks good to me. I merged main into it. It's pending @yoav-steinberg 's review.

yoav-steinberg

Thumbs up 👍
But I'd like you to open issues for unfulfilled tasks in the top description. And also an additional issue for getting bring to import into a Namespace (Add an optional name field to the AST's scope as a Namespace in our type system).

This reverts commit 05fb820.

yoav-steinberg and others added 15 commits September 22, 2022 14:51

wip: Import JSII types to get bring cloud working.

c9422ef

Removed Nothing from out type system.

e84ce2f

Merge jsii resource clients into generate wing resources. Handle JSII Void return types as no return type in wing.

Merge branch 'main' into yoav/jsii_import

fd76050

No need to double check jsii_reflection api following #159.

d7348fb

WIP: JSII imports:

9cf1d49

* Added support fro `struct`s in parser/type_checker/jsification. * Import constructors (including skipping scope/id on resources). * Pass "self" argument to imported class methods.

wip: Import JSII "datatype" interfaces as wing structs.

fd039f5

Treat wingsdk cloud.Inflight as ~(any):any inflight function.

6916688

* Also added support for multiple struct inheritance in when importing JSII props. * Support importing wingsdk `Duration` types.

Struct literals (currently with a grammar hack @TypeName)

7e23309

also: Cleaned up method_call vs function_call in grammar/ast Fixed return type parsing

fix: removed Yoav's @ in struct literals

2b33b9a

oops

0c2e469

Merge branch 'main' into yoav/jsii_import

55b5433

Apply suggestions from code review

d1b2eb0

Co-authored-by: Chris Rybicki <chrisr@monada.co>

feat(wingc): bring local wing files

424902f

3p3r requested a review from yoav-steinberg October 11, 2022 19:29

3p3r mentioned this pull request Oct 11, 2022

Support multiple .w files in a a Wing program #144

Closed

yoav-steinberg and others added 12 commits October 12, 2022 10:49

Added support for namespace aliases on JSII brings.

cbe71e7

Also: * Fix inflight.w example based on real imported cloud.Bucket type. * Removed skipping type checking on `new` expressions when the type is resolved to an `Anything`, we don't expect custom types to be `Anything`'s anymore.

jisify: Remoce hack to always add scope and id to anything objects.

08ff9ac

This was there because we didn't really know the type of the `new` expression. Now the type is available through a the `Expr.evaluated_type`.

cr fix

e1271e5

cr fix

3dbae32

cr fix

2f3c6af

CR: Fix constructor name.

798f1fc

CR fix

e04275b

cr fix

e4388e5

Merge branch 'main' into yoav/jsii_import

2842678

Update libs/wingc/src/type_check/jsii_importer.rs

0c83f75

Co-authored-by: Elad Ben-Israel <elad.benisrael@gmail.com>

Support inheriting from from wingsdk.

c4c3575

fix grammar test

4185d9b

yoav-steinberg reviewed Oct 13, 2022

View reviewed changes

libs/wingc/src/capture.rs Outdated Show resolved Hide resolved

yoav-steinberg reviewed Oct 13, 2022

View reviewed changes

libs/wingc/src/jsiiify.rs Outdated Show resolved Hide resolved

3p3r added 3 commits October 13, 2022 12:13

Merge branch 'sep/wing_import' of github.com:monadahq/winglang into s…

f8518c7

…ep/wing_import

PR feedback addressed

abdb66b

fixed builds

96a0a04

yoav-steinberg reviewed Oct 20, 2022

View reviewed changes

libs/wingc/src/parser/bring.rs Outdated Show resolved Hide resolved

Merge branch 'main' into sep/wing_import

3636cb8

3p3r self-assigned this Oct 20, 2022

3p3r added the 🛠️ compiler Compiler label Oct 20, 2022

3p3r added this to the MVP-1 milestone Oct 20, 2022

3p3r linked an issue Oct 20, 2022 that may be closed by this pull request

Support multiple .w files in a a Wing program #144

Closed

Merge branch 'main' into sep/wing_import

a9b5e12

3p3r requested a review from yoav-steinberg October 26, 2022 16:08

3p3r changed the title ~~feat(wingc): bring local wing files~~ feat(compiler): bring local wing files Oct 26, 2022

yoav-steinberg approved these changes Oct 27, 2022

View reviewed changes

3p3r added 7 commits October 27, 2022 06:31

Merge branch 'main' into sep/wing_import

fe60b71

Merge branch 'main' into sep/wing_import

d0c5fdf

Merge branch 'main' into sep/wing_import

5c69e88

Merge branch 'main' into sep/wing_import

59991af

Merge branch 'main' into sep/wing_import

2d648e3

Merge branch 'main' into sep/wing_import

10023c5

fix lang server's build error with the new imports on parser instances

085c4a1

3p3r enabled auto-merge (squash) October 31, 2022 17:46

3p3r merged commit 05fb820 into main Oct 31, 2022

3p3r deleted the sep/wing_import branch October 31, 2022 17:58

3p3r mentioned this pull request Nov 1, 2022

bring cloud throws unsupported operation error #401

Closed

6 tasks

3p3r added a commit that referenced this pull request Nov 2, 2022

Revert "feat(compiler): bring local wing files (#252)"

8b54287

This reverts commit 05fb820.

staycoolcall911 mentioned this pull request Dec 28, 2022

Module System - Imports (bring): local .w files #476

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(compiler): bring local wing files #252

feat(compiler): bring local wing files #252

3p3r commented Oct 11, 2022

3p3r commented Oct 11, 2022

staycoolcall911 commented Oct 26, 2022

3p3r commented Oct 26, 2022

yoav-steinberg left a comment

feat(compiler): bring local wing files #252

feat(compiler): bring local wing files #252

Conversation

3p3r commented Oct 11, 2022

3p3r commented Oct 11, 2022

staycoolcall911 commented Oct 26, 2022

3p3r commented Oct 26, 2022

yoav-steinberg left a comment

Choose a reason for hiding this comment