-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pin node/npm version for build workflow #1496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
during npm install symlinks were not being created where required
Would enabling this flag make any difference maybe? https://docs.npmjs.com/cli/v8/commands/npm-install#install-links
Funnily enough, I think that's part of the "regression". A recent version of node 18 made npm 9 the default. I had already added that flag to the npmrc, I mistakenly thought this fixed the previous issue with supporting npm9 (but npmrc doesn't apply to subdirs, whoops). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Congrats! 🚀 This was released in Wing 0.5.22. |
Ok so during npm install symlinks were not being created where required. I believe this is some sort of regression with a new minor/patch version of node or npm. Using volta we already pin the node version locally, so it makes sense to do it in the workflow as well.
Removed any explicit node versioning where it is unnecessary.
Also combined all of the build into 1 command, because it shows the power of nx.
Fixes #1479 🤞
By submitting this pull request, I confirm that my contribution is made under the terms of the Monada Contribution License.