Pull KWin patches (2024-01-10 - 2024-05-23) #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accidentally pressing any shortcut shouldn't take down the whole session. If a compositor isn't reponsive but can still process shortcuts for some reason, you can still switch to a different virtual terminal to explicitly kill it from there.
The current implementation of the `<N>` suffix is still buggy and its benefits are doubtful. One could argue that visual aids such as window thumbnails or highlighting the windows are better. On its own, these numbers don't have strong connections to the windows and can change on a whim. Co-authored-by: Roman Gilg <subdiff@gmail.com>
The documentation of NETRootInfo::activate() says that it should be called after creating the NETRootInfo object to read properties. However, it's called in two places: VirtualDesktopManager::setRows() and Workspace::initializeX11(). At quick glance, there's no justifying reason to call activate() in setRows(), it doesn't fit the purpose of setRows(). This change re-arranges NETRootInfo initialization code so it makes more sense.
Explicitly discard the return value. This is an error otherwise with GCC.
Needs to be further investigated. Only fails with release builds.
It improves the visuals of the switcher when there are no entries to display.
Brings it back.
The KF6::ConfigWidget dependency can be replaced with smaller ones.
Replace old "closest" and "natural" layout algorithms with new layout algorithm. The new layout algorithm tries to - use screen space efficiently, given diverse geometries of windows - be aesthetically pleasing - and minimize movement of windows from initial positions. More concretely, find a layered layout, where each layer, or strip, is a row or column. Ensure that different strips have similar widths, and use binary search to find a packing with similar aspect ratio to the layout area. Within each strip, minimize horizontal movement (for rows) or vertical movement (for columns) of windows. Run time is O(n) (up to log factors), where n is the number of windows. CCBUG: 453749 BUG: 450263 BUG: 477833 BUG: 478097 BUG: 477830
Signed-off-by: Falko Becker <falko.becker@mbition.io>
Currently desktop grid view is missing the selection rectangle when hovered over a desktop. This adds the selection rectangle on hover, since it used to be there before three-state design. Currently selected desktop has thinner and different colored border.    BUG:481812
BUG: 482191
The autohidden panels "blink" because this effect animates their opacity. The dock windows are animated because, as the comment says, the old effect animated almost every window. Conceptually, animating docks doesn't align with the purpose of this effect.
QuickEffect::setDelegate is exposed QML API. The lifespan of assigned objects is therefore managed by the QML engine, and we should be watching for deletion not actually deleting it.
By design, these categories of content can run arbitrary code on the system. This makes them security-sensitive and risky, so we need to inform the user about it. Depends on https://invent.kde.org/frameworks/knewstuff/-/merge_requests/309
Now that we have Kirigami.Units.cornerRadius, there's a central source of truth for corner radius so don't have to use random numbers for these anymore. Part of https://invent.kde.org/teams/vdg/issues/-/issues/45.
This is a hidden destructive action[1] in a context where users are not primed to expect it. It's also largely unnecessary since the delegates already show a delete button on hover, and deleting virtual desktops isn't such a common task that it benefits from an accelerator. Let's remove it for safety. [1] It's destructive because user-created state on the deleted virtual desktop is lost--with no confirmation or undo, to boot. BUG: 484999 FIXED-IN: 6.1
To clarify that the toggle action merely temporarily disables the blue light filter, rather than turning the schedule off permanently like the "Disbaled" setting in the KCM does, use "suspend/resume" terminology instead of "off/on" in the keyboard shortcut and OSD. Follow-up on plasma-workspace!4262 CCBUG: 486647
After porting to KConfigXT settings some time ago, there was still an inefficient and error-prone codepath between the `RuleBook` (which keeps the runtime list of `Rules`) and the `RuleBookSettings` (responsible for config reads and saves), in the form of the `setRules()` method. We can eliminate the `setRules()` codepath, reducing unnecessary runtime process and file access operations, and instead: - Keep track of the config `id` in the `Rules` objects - Keep a single `RuleBookSettings` object as a member - Modify or delete the discarded rules settings directly - Save when necessary This also fixes two bugs/pitfalls of the previous solution: - the config group id for each rule is now preserved instead of creating new ones - no leftovers on the config file for the discarded groups and entries Setting custom configs for the integration tests still works unchanged. BUG: 446381 FIXED-IN: 6.1 Co-authored-by: Roman Gilg <subdiff@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #25 +/- ##
==========================================
+ Coverage 50.55% 50.66% +0.10%
==========================================
Files 941 939 -2
Lines 87404 87348 -56
Branches 45754 45411 -343
==========================================
+ Hits 44190 44257 +67
+ Misses 39697 39322 -375
- Partials 3517 3769 +252 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to listings in #24.