CI improvements #14
CI improvements #14
Commits on Mar 4, 2024
-
refactor: adapt to Wrapland subsurface change
Now uses references instead of QPointer.
-
Add infrastructure and a CI job to run the static analysis tool clang-tidy. For now we only enable two checks. The goal is to progressively enable more checks until we at least cover all the default checks. For now the ci job is stopping short of actually running clang-tidy though because the GitHub Actions runner consistently terminate likely due to oom. Locally clang-tidy can be run with the new Python script in tooling/analysis.
-
fix: store event filters as raw pointers
Instead of using QPointers, which is marked by clang-tidy.
-
fix: store implict grab without QPointer
The QPointer is marked by clang-tidy.
-
Instead of calling delete on a raw pointer.
-
refactor: replace Qt smart pointers with STL ones
This also fixes a clang-tidy warning about delete-after-free.
-
fix: store window thumbnail item fields without QPointers
The QPointers are marked by clang-tidy as use-after-free.
-
fix: assert not dividing by zero
This was marked by clang-tidy. For now we just assume that we have the precondition that these values can't be zero and assert on it.
-
fix(plugin): store internal window handle without QPointer
This was marked by clang-tidy.
-
fix(plugin): store expo layout without QPointer
This was marked by clang-tidy.
-
test: get shadow as regular raw pointer
The QPointer is not needed here. Fixes a clang-tidy warning.
-
ci: create test build with GCC
Instead of having a single clang/coverage build for all statid and dynamic analysis, adapt the CMake presets to have different presets for test builds with coverage using clang and gcc. We also directly switch the ci coverage build to the gcc preset. This allows to use gcc-only features in the coverage reporting.
-
ci: exclude throw branches when calculating coverage
Without the exclusion nearly everything is marked as partial hit only. See also [1][2]. [1] https://gcovr.com/en/5.0/faq.html#why-does-c-code-have-so-many-uncovered-branches [2] https://stackoverflow.com/q/42003783
-
ci: ignore gcov no working dir found error
gcov executable is failing on finding Catch2 source, which is built via FetchContent. For now ignore the error. The coverage reporting seems to work anyway.
-
ci: store coverage reports for standard retention period
The default retention duration for artifacts is 90 days with GitHub Actions. These reports are rather small in size. We may just store them for this period as they might be useful sometimes when comparing them to Codecov results.
-
The most recent release works again. The regresssion from gcovr 6, and why gcovr 5 was used, has been fixed.
