Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FluidNC usability fixes #2135

Merged
merged 4 commits into from
Jan 21, 2023
Merged

FluidNC usability fixes #2135

merged 4 commits into from
Jan 21, 2023

Conversation

breiler
Copy link
Collaborator

@breiler breiler commented Jan 21, 2023

Made a couple of usability changes to the FluidNC implementation:

  • When stopping a running GCode program it will no longer fully reset the controller
  • When initializing and it starts in Alarm or Hold state it will now do a quick check if it is finite and requires a reset
  • Made the command text area active on alarms to be able to reconfigure the controller
  • Made the console window focusable again to be able to copy text
  • Made the file browser openable on alarm state

@breiler
Fixed usability issues when using FluidNC
e8d412f 
* Made the command text area active on alarms
* Made the console window focusable again to be able to copy text
* Made the file browser to open on alarm state
@breiler
Do not do a full reset of the FluidNC controller when canceling a pro…
d3a37ab 
…gram
@breiler
Small refactoring removing duplicated code
e3f1e3c
@breiler
Introduced a check to see if the Alarm or Hold states are the ones th…
d57d730 
…at can't be recovered from and do a reset of the controller.

Did some refactoring to make parts of the code easier to unit test.
@breiler breiler merged commit f49b390 into winder:master Jan 21, 2023
@breiler breiler deleted the bugfix/fluidnc-usability branch January 23, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@breiler