Skip to content

Commit

Permalink
Drop support for Python 3.8 (#160)
Browse files Browse the repository at this point in the history
  • Loading branch information
willkg committed Oct 29, 2024
1 parent 46ec4fc commit c6feb2a
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

strategy:
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
python-version: ['3.9', '3.10', '3.11', '3.12']

name: Python ${{ matrix.python-version}}
steps:
Expand Down
10 changes: 9 additions & 1 deletion HISTORY.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
History
=======

5.1.0 (in development)
----------------------

**Backwards incompatible changes**

* Dropped support for Python 3.8 (#160)


5.0.0 (June 24th, 2024)
-----------------------

Expand Down Expand Up @@ -35,7 +43,7 @@ History
* Add ``RegisteredMetricsFilter`` metrics filter making it easier to enforce
metrics can only be emitted if documented. (#15)

**Backwards incompatibel changes**
**Backwards incompatible changes**

* Dropped support for Python 3.7 (#121)

Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ clean: ## Clean build artifacts

.PHONY: format
format: ## Format files
tox exec -e py38-lint -- ruff format
tox exec -e py39-lint -- ruff format

.PHONY: lint
lint: ## Lint files
tox -e py38-lint
tox -e py39-lint

.PHONY: test
test: ## Run tox to test across supported Python versions
Expand Down
17 changes: 7 additions & 10 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,14 @@ readme = "README.rst"
keywords = ["metrics", "datadog", "statsd"]
authors = [{name = "Will Kahn-Greene"}]
license = {text = "MPLv2"}
requires-python = ">=3.8"
requires-python = ">=3.9"
dependencies = []
classifiers = [
"Development Status :: 5 - Production/Stable",
"Intended Audience :: Developers",
"License :: OSI Approved :: Mozilla Public License 2.0 (MPL 2.0)",
"Natural Language :: English",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand All @@ -36,8 +35,7 @@ dev = [
"check-manifest",
"pytest",
"ruff",
"Sphinx==6.2.1; python_version <= '3.8'",
"Sphinx; python_version > '3.8'",
"Sphinx",
"sphinx_rtd_theme",
"time-machine",
"tomli>=1.1.0; python_version < '3.11'",
Expand All @@ -55,7 +53,7 @@ build-backend = "setuptools.build_meta"

[tool.ruff]
line-length = 88
target-version = "py38"
target-version = "py39"
src = ["src"]

[tool.ruff.lint]
Expand All @@ -79,16 +77,14 @@ filterwarnings = [
legacy_tox_ini = """
[tox]
envlist =
py38
py38-lint
py39
py39-lint
py310
py311
py312
[gh-actions]
python =
3.8: py38
3.9: py39
3.10: py310
3.11: py311
Expand All @@ -100,8 +96,9 @@ commands =
pytest {posargs} tests/
pytest --doctest-modules --pyargs markus
[testenv:py38-lint]
basepython = python3.8
[testenv:py39-lint]
allowlist_externals = ruff
basepython = python3.9
changedir = {toxinidir}
commands =
ruff format --check src tests
Expand Down

0 comments on commit c6feb2a

Please sign in to comment.