Module Issue with useOpensearchDashboards method #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: keskami <kkak808@gmail.com>
joshuarrrr
reviewed
Nov 28, 2023
Comment on lines
16
to
17
| "optionalPlugins": [], | ||
| "requiredBundles": ["opensearchDashboardsUtils", "opensearchDashboardsReact", "home"] |
There was a problem hiding this comment.
No need to add these required bundles, as opensearchDashboardsReact is already in the requiredPlugins section. We may eventually decide to move it to requiredBundles, but it should only be in one or the other.
Suggested change
| "optionalPlugins": [], | |
| "requiredBundles": ["opensearchDashboardsUtils", "opensearchDashboardsReact", "home"] | |
| "optionalPlugins": [], |
|
|
||
| import { VisOptionsProps } from 'src/plugins/vis_default_editor/public'; | ||
| import { DrilldownVisParams } from './types'; | ||
| import { useOpenSearchDashboards } from 'src/plugins/opensearch_dashboards_react/public'; |
There was a problem hiding this comment.
Looking at most other imports, I think this needs to be relative:
Suggested change
| import { useOpenSearchDashboards } from 'src/plugins/opensearch_dashboards_react/public'; | |
| import { useOpenSearchDashboards } from '../../opensearch_dashboards_react/public'; |
Comment on lines
30
to
34
| services: { savedObjectsClient }, | ||
| } = useOpenSearchDashboards<DrilldownServices>(); | ||
|
|
||
| useEffect(() => { | ||
| const saved = savedObjectsClient.find({ |
There was a problem hiding this comment.
That's not quite the right format for the service. It should be:
Suggested change
| services: { savedObjectsClient }, | |
| } = useOpenSearchDashboards<DrilldownServices>(); | |
| useEffect(() => { | |
| const saved = savedObjectsClient.find({ | |
| services: { savedObjects }, | |
| } = useOpenSearchDashboards<DrilldownServices>(); | |
| useEffect(() => { | |
| const saved = savedObjects?.client.find({ |
…rds' Signed-off-by: keskami <kkak808@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
for review, when using useOpensearchDashboards to find all saved objects, I get this error:
Module not found: Error: Can't resolve 'src/plugins/opensearch_dashboards_react/public' in '/Users/kk/Desktop/Github/OpenSearch-Dashboards/src/plugins/vis_type_drilldown/public'
Other than that, added a EuiSuperSelect which will eventually hold the saved objects
Issues Resolved
Screenshot
Error:
Testing the changes
Check List
yarn test:jestyarn test:jest_integration