Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Implement mock drilldown plugin #2

Open
wants to merge 32 commits into
base: feature/drilldown
Choose a base branch
from
Open

[Feature] Implement mock drilldown plugin #2

wants to merge 32 commits into from

Conversation

willie-hung
Copy link
Owner

@willie-hung willie-hung commented Nov 16, 2023 •
edited
Loading

Description

Implemented a drilldown plugin allows users to design their own navigation controls, customized to fit their specific preferences and workflow requirements.

Issue Resolved

Resolves #3

Demo

Demo 1 (Implemented a new visualization type)

demo.mov

Demo 2 (Implemented it's own drilldown functionality)

drilldown.card.demo.mov

Demo 3 (Multiple drilldown form with external website navigation)

Render_multiple_form.mov

Testing the changes

No test included.

@willie-hung
Implement mock drilldown plugin
ed9a73a 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
willie-hung and others added 4 commits November 19, 2023 17:58
@willie-hung
Implement add card form
b5b3c34 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@keskami
-s
dfa2d45
@keskami
Module Issue for useOpensearchDashboard
f2ed6f5 
Signed-off-by: keskami <kkak808@gmail.com>
@willie-hung
Render multiple drilldown forms
b6c6854 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
joshuarrrr
joshuarrrr reviewed Nov 27, 2023
View reviewed changes
Copy link

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Willie-The-Lord Excellent start - most of my comments can also be addressed in follow-up PRs and commits, so feel free to merge as-is if it allows the team to better split up tasks and keep moving forward.

src/plugins/vis_type_drilldown/public/drilldown_vis.ts Outdated Show resolved Hide resolved
src/plugins/vis_type_drilldown/README.md Outdated Show resolved Hide resolved
src/plugins/vis_type_drilldown/.i18nrc.json Outdated Show resolved Hide resolved
src/plugins/vis_type_drilldown/.eslintrc.js Outdated Show resolved Hide resolved
src/plugins/vis_type_drilldown/opensearch_dashboards.json Outdated Show resolved Hide resolved
src/plugins/vis_type_drilldown/public/drilldown_options.tsx Outdated Show resolved Hide resolved
src/plugins/vis_type_drilldown/public/drilldown_options.tsx Outdated Show resolved Hide resolved
src/plugins/vis_type_drilldown/public/drilldown_options.tsx Outdated Show resolved Hide resolved
src/plugins/vis_type_drilldown/public/drilldown_vis.ts Outdated Show resolved Hide resolved
src/plugins/vis_type_drilldown/public/drilldown_vis.ts Show resolved Hide resolved
@keskami
Added Super Select and Grabbed URL of Saved Object with Type 'Dashboa…
d50a5a9 
…rds'

Signed-off-by: keskami <kkak808@gmail.com>
@keskami keskami mentioned this pull request Nov 29, 2023
Closed
7 tasks
@keskami keskami mentioned this pull request Nov 29, 2023
Merged
7 tasks
@willie-hung
Remove unuse import/reference and implement multiple forms
0452554 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@willie-hung willie-hung changed the title Implement mock drilldown plugin [Feature] Implement mock drilldown plugin Nov 29, 2023
@willie-hung
Merge pull request #7 from keskami/feature/mock-drilldown
7e080b5 
Added SuperSelect and Grabbed URL of SavedObject with Type 'Dashboard'
@willie-hung
Remove unused import/reference/files
891910c 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@willie-hung
Implement multiple drilldown forms & remove unused import
93f08de 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@willie-hung
Remove duplicate files
1fa7e7b 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@shawnkchan shawnkchan mentioned this pull request Nov 30, 2023
Closed
7 tasks
@willie-hung
Merge branch 'feature/mock-drilldown' into feature/multiple-form
d208217 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@willie-hung
Resolve conflicts & remove unused imports
4c9005c 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@shawnkchan shawnkchan mentioned this pull request Nov 30, 2023
Closed
7 tasks
willie-hung and others added 5 commits November 29, 2023 23:28
@willie-hung
Integrated the destination select into the drilldown form
41dc3aa 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@keskami
Fixed opensearch_dashboards.json bug
53bbe11 
Signed-off-by: keskami <kkak808@gmail.com>
@willie-hung
Fix canvas rendering bug
05855cb 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@willie-hung
Merge pull request #9 from Willie-The-Lord/feature/multiple-form
fc0915f 
[Feature] Implement multiple drilldownform
@keskami
rebase
1380930 
Signed-off-by: keskami <kkak808@gmail.com>
@willie-hung willie-hung mentioned this pull request Nov 30, 2023
Merged
@shawnkchan shawnkchan mentioned this pull request Dec 1, 2023
Merged
7 tasks
shawnkchan and others added 10 commits December 1, 2023 16:49
@shawnkchan
fix: adds i18n wrappers
92a48c8
@willie-hung
Update src/plugins/vis_type_drilldown/public/components/card_form.tsx
bf26be0 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@willie-hung
Update src/plugins/vis_type_drilldown/public/components/card_form.tsx
5771efc 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@willie-hung
Update src/plugins/vis_type_drilldown/public/components/card_form.tsx
1b15f1d 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@willie-hung
Update src/plugins/vis_type_drilldown/public/components/card_form.tsx
8d10b4c 
Signed-off-by: Willie Hung <willie880201044@gmail.com>
@willie-hung
Merge pull request #12 from shawnkchan/shawnMockDrilldown
5d6ab7a 
Shawn mock drilldown
@keskami
Switch Statement for Static URL and Dashboard Navigation
f7c2393 
Signed-off-by: keskami <kkak808@gmail.com>
@keskami
Merge branch 'Willie-The-Lord:feature/mock-drilldown' into feature/mo…
5b1b6f0 
…ck-drilldown
@keskami
Switch Statement for Static URL and Dashboard Navigation
0e3acd8 
Signed-off-by: keskami <kkak808@gmail.com>
@keskami
Switch Statement for Static URL and Dashboard Navigation
0c3d550 
Signed-off-by: keskami <kkak808@gmail.com>
@keskami keskami mentioned this pull request Dec 2, 2023
Merged
7 tasks
@willie-hung
Merge pull request #13 from keskami/feature/mock-drilldown
7e87845 
Switch Statement for Static URL and Dashboard Navigation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuarrrr joshuarrrr joshuarrrr left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@willie-hung willie-hung

@keskami keskami

@shawnkchan shawnkchan

Labels
first-time-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@willie-hung @joshuarrrr @keskami @shawnkchan