Test enhancement #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
May 28, 2019
src/JsonpCallbackValidator.php
Outdated
| @@ -1,5 +1,7 @@ | |||
| <?php | |||
|
|
|||
| namespace JsonpCallbackValidator; | |||
There was a problem hiding this comment.
this is a BC break, because you are changing the class name
There was a problem hiding this comment.
Hi @stof, thank you for your reply.
I've reverted JsonpCallbackValidator namespace.
peter279k
force-pushed
the
test_enhancement
branch
from
93c7c0e to
fcea5cf
Compare
|
I kinda fixed the test suite in #11 so I don't think this is necessary. If you feel otherwise, which is fine, please submit a new PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed log
psr-4autoload becausepsr-ois deprecated.hhvmversion be failed because it seems this version will be failed in Travis CI build.