Encode Crystal enum args as integers #286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decoding enum values is already supported in DB, but encoding still requires explicitly specifying
enum.value
in query args. This PR uses thevalue
property implicitly.An argument could be made that it would be easier to understand the query if we use the string representations of the Crystal
enum
s instead, but I'm proposing the numeric values for three reasons:int4
values takes up less space than atext
@[Flags]
enums painful to parse, but the integer representation makes them trivialenum
is anInt32
Example: