♻️ Update regex to be lazy and handle !
in text
#1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts the regex to use a match all (
.+
) token with the addition of being lazy (?
- match as little as possible, consuming as needed) instead of greedy (match as much as possible, giving back as needed) which allows for using an!
in the text.Regex Explanation
[!]{2} - match two leading exclamation points
(?P<class>.+?)[|^] - match anything once or more (lazily) until a
|
or^
is found(?P<text>.+?(?=[!]{2})) - match anything once or more (lazily) until two consecutive
!
s are found(?=(?P<lookahead>[!]{3}))? - check if there are three consecutive
!
s(?(lookahead)(?P<exclaim>!)) - if three consecutive
!
s were found match one!
[!]{2} - match two trailing exclamation points
Tested Cases
!
anywhere in the text!
anywhere in the classNOTE: The edge case of an exclamation point at the end of the
text
(i.e. having 3!
in a row) required appending an!
to thetext
See here for tested cases: https://regex101.com/r/BZnHIO/2
NOTE:
Markdown is using the python standard library
re
as its regex library.re
doesn't allow for conditional expressions unless the condition is a previous capture group - https://docs.python.org/3/library/re.html?highlight=(?(id/name). This forced a conditional matching capture group named "lookahead" which is then used in the conditional expression instead of having the lookahead inline in the conditional.