Fix for WFMP-269, Support multiple deployments in the package goal #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfdenise
force-pushed
the
multiple-deployments
branch
2 times, most recently
from
e67c069
to
81bfc07
Compare
jamezp
requested changes
Sep 9, 2024
plugin/src/main/java/org/wildfly/plugin/provision/PackageServerMojo.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/wildfly/plugin/provision/DeploymentResolution.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/wildfly/plugin/provision/DeploymentResolution.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/wildfly/plugin/provision/DeploymentResolution.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/wildfly/plugin/provision/PackageServerMojo.java
Show resolved
Hide resolved
plugin/src/main/java/org/wildfly/plugin/provision/PackageServerMojo.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/wildfly/plugin/provision/PackageServerMojo.java
Show resolved
Hide resolved
jfdenise
force-pushed
the
multiple-deployments
branch
from
81bfc07
to
b37894f
Compare
|
@jamezp I implemented your great comments. Thank-you! |
|
@torsten-liermann , it would be great if you could validate that this solution works for you. You have been the main source of requirement for it! |
|
Thank you for the quick implementation. The implementation works as expected for the example project. I would have designed the idea similarly to the maven-ear-plugin: deploying all dependencies defined in the pom.xml and structuring the "deployments" configuration analogous to the "modules" configuration. |
jamezp
requested changes
Sep 11, 2024
plugin/src/main/java/org/wildfly/plugin/provision/PackageServerMojo.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFMP-269
Updated documentation for multiple deployments and Glow (that was missing).