Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-6755] Move the org.wildfly.security:wildfly-elytron-dynamic-ssl artifact into its own module #6066

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yersan
Copy link
Collaborator

@yersan yersan commented Jul 10, 2024

Supersedes #5947

Jira issue: https://issues.redhat.com/browse/WFCORE-6755

See https://wildfly.zulipchat.com/#narrow/stream/174184-wildfly-developers/topic/Layers.20and.20optional.20packages.

This PR includes #5947 but removes the community stability property configuration from org.wildfly.security.elytron-dynamic-ssl JBoss Modules module and adds its package as required for the Elytron layer. Until getting a better approach for this case, this will fix the issue reported by the test case where this module was not provisioned when using Elytron Galleon Layer and ensure we can use default stability level out of the box when the server is built targetting this stability level.

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Jul 10, 2024
@wildfly-ci
Copy link

Core -> Full Integration Build 13655 outcome was FAILURE using a merge of 1fc8829
Summary: Tests passed: 169, ignored: 4; exit code 1 (Step: Test full with JDK 11 (Maven)) (new) Build time: 00:17:42

@yersan yersan requested review from darranl and fjuma July 11, 2024 08:21
@yersan yersan added 26.x and removed 25.x labels Jul 11, 2024
@yersan
Copy link
Collaborator Author

yersan commented Aug 16, 2024

Hello @fjuma / @darranl , a friendly reminder that I requested any of you to review this one, thanks!

@yersan
Copy link
Collaborator Author

yersan commented Aug 16, 2024

@fjuma / @darranl, sorry for the noise, forget my last comment, I have to review the current status first since I lost track of this one, I'm going to remove you from the review until this one gets refreshed

@darranl
Copy link
Contributor

darranl commented Aug 16, 2024

@yersan FYI I will be working on a PR to promote this to default soon, although would be good to know we could solve this situation if it comes up again so I think still worth proceeding for now.

@darranl
Copy link
Contributor

darranl commented Sep 19, 2024

@yersan are we proceeding with this one?

@yersan
Copy link
Collaborator Author

yersan commented Sep 20, 2024

@darranl I want to back to this once we have passed the feature freeze, I plan to take a closer look next week

@yersan
Copy link
Collaborator Author

yersan commented Oct 1, 2024

@darranl kicked it off again, I've added valid-for-stability to the package dependency for Elytron layer, does mean, the package will not be provisioned for an stability level with higher stability than "community"

@yersan yersan requested a review from darranl October 1, 2024 14:23
@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26.x Blocker deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants