Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-6383] throwing boot errors if super.boot fails #5659

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

istudens
Copy link
Contributor

Issue: https://issues.redhat.com/browse/WFCORE-6383

With this fix the ModelTestControllerService.boot() always throws new BootOperationFailedException if super.boot returns false.
Note that a few test-cases had to be changed according to it.
Regarding "BTW, I think the entire class can and should be package protected, but if there's some outside use I've missed, then never mind.", it is not possible as BootErrorCollector is also used outside the package.
Note 2: This will need a fix in WildFly code base in two PicketLink Subsystem tests. I will create a separate Jira for it.

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Sep 14, 2023
@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@istudens
Copy link
Contributor Author

@bstansberry can you review this please? thanks

Copy link
Collaborator

@yersan yersan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you prepare a custom integration Job using your topic branches and link them to this PR?

WildFly requires this PR and the other way around, so an integration Job picking up your topic branches will allow us to test both PRs in conjunction before merging them.

Integration Jobs are available at https://ci.wildfly.org/buildConfiguration/WF_WildFlyCoreIntegrationExperiments

@istudens
Copy link
Contributor Author

istudens commented Sep 25, 2023

@yersan Ok, I gave it a try, it is job no 1192.

@istudens
Copy link
Contributor Author

@yersan The integration job passed successfully, see https://ci.wildfly.org/buildConfiguration/WF_WildFlyCoreIntegrationExperiments/392051

Copy link
Collaborator

@yersan yersan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @istudens , looks good to me, we will merge this one as the last PR for the final release.

Could you rebase and fix the conflicts?

@yersan yersan added the hold Do not merge this PR label Sep 27, 2023
@istudens
Copy link
Contributor Author

Thanks @istudens , looks good to me, we will merge this one as the last PR for the final release.

Could you rebase and fix the conflicts?

done

@wildfly-ci

This comment was marked as resolved.

@wildfly-ci

This comment was marked as resolved.

@yersan yersan added the 22.x label Oct 4, 2023
@yersan yersan merged commit b90ea4e into wildfly:main Oct 9, 2023
10 of 12 checks passed
@yersan
Copy link
Collaborator

yersan commented Oct 9, 2023

Thanks @istudens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes hold Do not merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants