WFCORE-6407 Deprecate non-default contructors from AbstractAddStepHandler and AbstractWriteAttributeHandler #5563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
deps-ok
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Added hold label until I sort out some missing domain testsuite changes. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Full-integration tests failures are addressed by wildfly/wildfly#17007 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
pferraro
force-pushed
the
WFCORE-6407
branch
from
008bcbb
to
11a9840
Compare
|
Rebased against main. |
…rather than UnsupportedOperationException.
…dler and AbstractWriteAttributeHandler
…epHandler.INSTANCE.
… be explicitly avoided, as these create unnecessary no-op runtime steps.
…or in discovery subsystem. Use static OperationStepHandler instances wherever possible.
…n though attribute is optional.
…ity references, since these are not present in the model. Aliases can also be ignored as these are constrainted by the target attribute.
…ute definition creation/registration.
…Handler and ReloadRequiredWriteAttributeHandler constructors.
pferraro
force-pushed
the
WFCORE-6407
branch
from
11a9840
to
608409e
Compare
bstansberry
approved these changes
Sep 28, 2023
|
Thanks @pferraro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFCORE-6407
Essentially, this change avoids the need for subsystems to specify AttributeDefinition instances to their add resource and write-attribute operation handlers.
See jira for full rationale.
This change will require minor unit test updates to wildfly, so expect failures in full integration test runs until those fixes are available and merged.
Given that this proposed change affects every add/write-attribute operation, I wanted to make this available for review/feedback as soon as possible.
This should simplify the creation and registration of add and write-attribute operation handlers as well as further reduce our memory footprint, since many operation handler implementations can now be consolidated both within and across subsystems.
Requires #5644Merged.