JBEAP-20756 #515
JBEAP-20756 #515
Conversation
… SENT and CONSUMING to READY, and at awaitResponse, reset timeout to 0 if it is expired. Update asserts accordingly.
This allows the original failure to be propagated.
…en writing messages to the client, or else the new message ack timeout configuration in remoting will not be visible in the logs. Also, if an IOException is thrown when writing module availability messages, we must close the channel, or else the client will hang, as the client waits for this message before sending the invocation request to server.
|
Sure, @tadamski ! I have just looked at the commits, and they seem fine. Still, I'm also going to review the Jiras to entirely refresh my memory before giving my final okay, just to make sure I'm not missing anything. |
|
thanks @fl4via! |
|
Can we merge this one ? |
|
Hello @tadamski @fl4via , did you manage to review, so this can be merged? (These commits were/are released in EAP 7.3.6 / 7.4.1 from private branches. According to the usual rules, we would expect them to be ported to this upstream repository, to avoid a situation when a future version of EJB Client is released without these fixes, hence creating a regression if such version gets consumed by a product.) |
|
@tadamski @chengfang please merge this one in upstream, we need 5d7f423 this commit present in next jboss-ejb-client upgrade, Thanks. |
|
@TomasHofman @soul2zimate merged |
@fl4via Could you please review?