[EJBCLIENT-309] Add expiration for failed connections in discovery provider #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmlloyd I'm unsure about hard coding timeout instead of using a property to configure it. Wdyt about this, David? |
|
Yeah we don't want to hard code values. Also currentTimeMillis should not be used (use nanoTime instead). |
fl4via
requested changes
Jan 19, 2019
src/main/java/org/jboss/ejb/protocol/remote/RemotingEJBDiscoveryProvider.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Jan 21, 2019
src/main/java/org/jboss/ejb/protocol/remote/RemotingEJBDiscoveryProvider.java
Outdated
Show resolved
Hide resolved
ivagulin
changed the title
|
fl4via
approved these changes
Feb 7, 2019
ivagulin
force-pushed
the
failed-connections-expiration
branch
from
adb40f3 to
8472d22
Compare
added 2 commits
February 8, 2019 00:18
- add expiration for failed connections in discovery provider
- make recheck interval configurable - use nanoTime
ivagulin
force-pushed
the
failed-connections-expiration
branch
from
8472d22 to
0009231
Compare
fl4via
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC pull-request to address following scenario:
Steps
Actual Result
all calls from ejb-remote node fails with "connection refused". RemotingEJBDiscoveryProvider not try to establish connection to nodeB
Expected Result
ejb calls working. RemotingEJBDiscoveryProvider try to establish connection to nodeB
jira reference
https://issues.jboss.org/browse/EJBCLIENT-309