Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EJBCLIENT-281] RequestSendFailedException extends EJBException #327

Merged
merged 1 commit into from
Oct 26, 2017

Conversation

@@ -54,7 +56,7 @@ public RequestSendFailedException(final String msg) {
* @param cause the cause
*/
public RequestSendFailedException(final Throwable cause) {
super(cause);
super(throwableToException(cause));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather that this method return "null" when cause is not an Exception, and then call initCause() just below.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tip! 👍

@thaarok
Copy link
Author

thaarok commented Oct 26, 2017

Updated.

@dmlloyd dmlloyd merged commit a5b2e01 into wildfly:master Oct 26, 2017
@thaarok thaarok deleted the EJBCLIENT-281 branch October 30, 2017 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants