EJBCLIENT-223 - Protocol issues relating to legacy compatibilty #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
reviewed
May 3, 2017
| writeFailedResponse(invId, e); | ||
| } catch (Throwable t) { | ||
| // Narayana uses Errors, Exceptions, and RuntimeExceptions | ||
| if (t instanceof VirtualMachineError) { |
There was a problem hiding this comment.
In this case we should still write a failed response. It should be a SystemException.
dmlloyd
previously requested changes
May 3, 2017
| throw (VirtualMachineError)t; | ||
| } | ||
|
|
||
| writeFailedResponse(invId, t); |
There was a problem hiding this comment.
I'd rather see a SystemException wrapping here because otherwise weird exceptions will be thrown remotely that shouldn't appear there (like Errors).
pom.xml
Outdated
| @@ -58,7 +58,7 @@ | |||
| <version.org.wildfly.naming.client>1.0.0.Beta14</version.org.wildfly.naming.client> | |||
| <version.org.wildfly.discovery>1.0.0.Beta10</version.org.wildfly.discovery> | |||
| <version.org.wildfly.security.elytron>1.1.0.Beta37</version.org.wildfly.security.elytron> | |||
| <version.org.wildfly.transaction-client>1.0.0.Beta21</version.org.wildfly.transaction-client> | |||
| <version.org.wildfly.transaction-client>1.0.0.Beta22-SNAPSHOT</version.org.wildfly.transaction-client> | |||
There was a problem hiding this comment.
I'll get a release out soon for this.
| | (encodedForm[nodeNameLength + 1] & 0xff) << 16 | ||
| | (encodedForm[nodeNameLength + 2] & 0xff) << 8 | ||
| | encodedForm[nodeNameLength + 3] & 0xff; | ||
| this.id = (encodedForm[nodeNameLength + 2] & 0xff) << 24 |
dmlloyd
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/EJBCLIENT-223