Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature-pack dependency to archetypes module to ensure correct build order #853

Closed
jamesnetherton opened this issue Sep 9, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@jamesnetherton
Copy link
Collaborator

This is a result of the duff advice I gave on IRC (sorry Thomas!):

<tdiesler> jnetherton, is it true that archetypes have no deps on any other wfc module?
<jnetherton> tdiesler, yes correct

This is actually not the case. The archetype unit tests depend on the subsystem having been built and packaged beforehand.

Best to put this module back into it's previous place before the itest module.

@jamesnetherton jamesnetherton self-assigned this Sep 9, 2015
@jamesnetherton jamesnetherton added this to the 3.1.0 milestone Sep 9, 2015
@jamesnetherton jamesnetherton changed the title Move archetypes module further down the buildchain Move archetypes module further down the build chain Sep 9, 2015
@tdiesler
Copy link
Contributor

A maven build cannot rely on the declared order of modules in the POM, it must instead use dependencies to define the build order. A build that does not use dependencies breaks --also-make

IOW, this should work:

mvn clean install -pl archetypes -am

@tdiesler tdiesler reopened this Sep 10, 2015
@jamesnetherton jamesnetherton changed the title Move archetypes module further down the build chain Add feature-pack dependency to archetypes module to ensure correct build order Sep 10, 2015
tdiesler pushed a commit to tdiesler/wildfly-camel that referenced this issue Sep 21, 2015
…rchetypes module to ensure correct build order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants