Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to load custom Kafka Serializer or Partition classes #819

Closed
jamesnetherton opened this issue Aug 17, 2015 · 7 comments
Closed

Unable to load custom Kafka Serializer or Partition classes #819

jamesnetherton opened this issue Aug 17, 2015 · 7 comments
Assignees
@tdiesler
Labels
bug
Milestone
4.0.0

Comments

@jamesnetherton
Copy link
Collaborator

Attempting to use custom Kafka serializer or partition classes with 0.8.2.0 passes through this Scala code:

val klass = Class.forName(className).asInstanceOf[Class[T]]

This results in org.apache.kafka:main ModuleClassLoader being used. Custom classes wont be available to this module so we end up with a CNFE.

KAFKA-2295 is proposing to fix this in 0.9.0. The patch provided attempts to use the TCCL. This will probably work for WildFly but maybe they should allow clients to specify what CL should be used.

@tdiesler thoughts on this?
@jamesnetherton jamesnetherton added this to the 3.1.0 milestone Aug 17, 2015
@jamesnetherton
Copy link
Collaborator Author

#775 is possibly related to this.

@tdiesler tdiesler self-assigned this Sep 7, 2015
@tdiesler tdiesler modified the milestones: 3.2.0, 3.1.0 Sep 9, 2015
@tdiesler
Copy link
Contributor

tdiesler commented Sep 9, 2015

Blocked on camel-2.16

@tdiesler tdiesler removed the blocked label Sep 30, 2015
@tdiesler tdiesler assigned jamesnetherton and unassigned tdiesler Sep 30, 2015
@tdiesler
Copy link
Contributor

Can this go into 3.1.0?

@jamesnetherton jamesnetherton modified the milestones: 3.1.0, 3.2.0 Sep 30, 2015
@tdiesler tdiesler modified the milestones: 3.2.0, 3.1.0 Sep 30, 2015
@jamesnetherton jamesnetherton modified the milestones: 3.2.0, 3.1.0 Sep 30, 2015
@jamesnetherton
Copy link
Collaborator Author

Seems that this will be dependent on Camel consuming Kafka 0.9.0.0 or greater

@jamesnetherton
Copy link
Collaborator Author

Cross ref: https://issues.apache.org/jira/browse/KAFKA-2295

jamesnetherton added a commit that referenced this issue Sep 30, 2015
@jamesnetherton
[relates #819] Add tests for custom kafka partitioners and serializers
4988c87
jamesnetherton added a commit that referenced this issue Oct 6, 2015
@jamesnetherton
[relates #819] Add tests for custom kafka partitioners and serializers
dd2d7e3
@jamesnetherton jamesnetherton added this to the 4.0.0 milestone Nov 25, 2015
@jamesnetherton jamesnetherton removed this from the 3.2.0 milestone Nov 25, 2015
@jamesnetherton
Copy link
Collaborator Author

Kafka 0.9.0 is finally released:

https://issues.apache.org/jira/browse/CAMEL-9361

jamesnetherton added a commit to jamesnetherton/wildfly-camel that referenced this issue Nov 26, 2015
@jamesnetherton
[WIP wildfly-extras#819]
cfd5112
@tdiesler tdiesler assigned tdiesler and unassigned jamesnetherton Mar 16, 2016
@tdiesler tdiesler removed the blocked label Mar 16, 2016
@tdiesler
Copy link
Contributor

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdiesler tdiesler

Labels
bug
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@tdiesler @jamesnetherton