Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure smartics-jboss-modules-maven-plugin changes are merged upstream #565

Closed
jamesnetherton opened this issue Apr 24, 2015 · 2 comments
Closed
Assignees
Labels
Milestone

Comments

@jamesnetherton
Copy link
Collaborator

Smartics finally have their latest plugin code on GitHub:

https://github.com/smartics/smartics-jboss-modules-maven-plugin

I agreed that I'd send a series of PRs with the changes that we have made so that the code can be reviewed.

Since we've invented an entirely new XML schema for the plugin, I think it's only fair that we:

  1. Document it and back up with an XSD.
  2. Add appropriate integration tests

If the changes are accepted, hopefully we can get a new plugin release and switch to using the upstream version.

@jamesnetherton jamesnetherton self-assigned this Apr 24, 2015
@jamesnetherton jamesnetherton added this to the 2.3.0 milestone Apr 24, 2015
jamesnetherton added a commit to jamesnetherton/wildfly-camel that referenced this issue May 1, 2015
@jamesnetherton
Copy link
Collaborator Author

Initial PR sent for addition of the V2 module schema smartics/smartics-jboss-modules-maven-plugin#4.

The other fixes and enhancements hang off of this so there is little value in creating PR's for those until this change is merged. Therefore, marking this issue as blocked for now.

@tdiesler tdiesler modified the milestones: 2.3.0, 3.0.0 Jun 1, 2015
@jamesnetherton
Copy link
Collaborator Author

Closing this. We've got all of the core functionality needed for us to switch to the upstream plugin onto upstream/master now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants