Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VersionsValidatorTest.testVersions() should list the problems rather than complaining about their number #2385

Closed
ppalaga opened this issue Jan 15, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@ppalaga
Copy link
Collaborator

ppalaga commented Jan 15, 2018

We should replace

Assert.assertEquals("Mapping problems", 0, problems.size());

with something like

Assert.assertEquals("Mapping problems", Collections.emptyList(), problems);
ppalaga added a commit to ppalaga/wildfly-camel that referenced this issue Jan 15, 2018
…hould list the

problems rather than complaining about their number
@jamesnetherton
Copy link
Collaborator

I noticed this too. But the test does have:

for (String line : problems) {
System.err.println(line);
}

So you do get some indication of what went wrong.

@ppalaga
Copy link
Collaborator Author

ppalaga commented Jan 15, 2018

Indeed, I got the indication, but not where I looked for it :).

One can also run the test from IDE and in such a case, the stderr may again stay away from dev's sight.

That said, I'd still prefer to get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants