Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T276281: Improve height setting when expanding down #98

Merged
merged 1 commit into from
Mar 17, 2021
Merged

T276281: Improve height setting when expanding down #98

merged 1 commit into from
Mar 17, 2021

Conversation

medied
Copy link
Contributor

@medied medied commented Mar 16, 2021

https://phabricator.wikimedia.org/T276281

Problem

When preview popup expands down with limited screen space, it's expanding too far down the screen and overflows the available screen space.

Solution

Let setPreviewMaxHeight also decide what's the most appropriate height when expanding down, similar to how we do it when expanding up.

hueitan
hueitan approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@hueitan hueitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jpita jpita merged commit 1eccccd into main Mar 17, 2021
@jpita jpita deleted the T276281 branch March 17, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hueitan hueitan hueitan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@medied @hueitan @jpita