Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stylelint check for unsupported browser features #87

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

stephanebisson
Copy link
Collaborator

Stylelint will output warnings for CSS features that may not fully work in our target browsers.

@stephanebisson stephanebisson mentioned this pull request Nov 6, 2020
2 tasks
Comment on lines +1 to +3
last 2 Chrome versions
last 2 Firefox versions
IE 11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this browserslist is so simple it looks curious

@stephanebisson stephanebisson merged commit 4640c4b into master Nov 9, 2020
@stephanebisson stephanebisson deleted the stylelint-no-unsupported-browser-features branch November 9, 2020 20:56
@hueitan
Copy link
Member

hueitan commented Nov 16, 2020

I don't how to deal with the warning Unexpected browser feature "flexbox" is only partially supported by IE11 unless not using flexbox in the gallery.

The current gallery slider works in IE11 using flexbox, I think that's because it uses only the container basic of flexbox, and doesn't deal with too much direction/width/align, so still within the partially supported feature.

@stephanebisson
Copy link
Collaborator Author

I've created #90 to turn these warnings off.

@stephanebisson stephanebisson restored the stylelint-no-unsupported-browser-features branch May 13, 2021 17:28
@stephanebisson stephanebisson deleted the stylelint-no-unsupported-browser-features branch May 13, 2021 17:30
@stephanebisson stephanebisson restored the stylelint-no-unsupported-browser-features branch July 28, 2022 12:57
@stephanebisson stephanebisson deleted the stylelint-no-unsupported-browser-features branch July 28, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants