-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T259233: Wikipedia Preview card dragging gestures #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something missing and recommend to do it
- Before expand, drag down should close the popup
- After expand, does drag down more than 60px too less? too sensitive?
- once drag match the threshold, apply the animation drag to the expanded (closed) position
- Tap CTA (Continue reading) doesn't expand the card height
- "throw" event that require duration calculation.
if ( !isHeader && !expanded || isHeader && expanded ) { | ||
containerBody.style.maxHeight = currentHeight + 'px' | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
insert the code e.preventDefault()
here (touchmove) to prevent lagging sometimes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like adding e.preventDefault()
messes with the text scrolling actually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opsss, then better don't have this code.
Cool, addressed 1, 2 & 4
Could you please elaborate on 3 & 5? |
Currently, when the
quick swipe within the given threshold, similar to gallery slider, quick swipe to get the next image instead of swiping more than 40% of the image, this gives a better experience for user who knows how to swipe. |
Alright I'd like to share this exploration sub-branch and have at least you and Sudhanshu play with it and see how it feels:
Some observations & thoughts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice gesture!
https://phabricator.wikimedia.org/T259233
Problem
Currently, users need to tap 'Continue reading' button expand preview card. We would like to improve the user experience by allowing users to also be able to drag on mobile to interact with preview card
Solution
Allow users to drag up to expand preview card, drag down to close it, following specified requirements:
Solution inspired from #56
TODOs