-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish compiled output to gh-pages #4
Conversation
at: . | ||
- add_ssh_keys: | ||
fingerprints: | ||
- "c3:03:93:79:5d:c7:23:b8:4a:4d:5d:41:e3:38:3f:84" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to understand more about this fingerprint..
https://superuser.com/questions/421997/what-is-a-ssh-key-fingerprint-and-how-is-it-generated
https://circleci.com/docs/2.0/configuration-reference/#filters
So it's meant to stay public on master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya I also have the same problem and who owns this fingerprint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a key that allows circleci to push to github. The private part is own by circleci and the public part is on github. The fingerprint is just to identify which key to use. This is not sensitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, and able to see build
and update-demo
running in CI.
https://phabricator.wikimedia.org/T240012
When there's a new commit on the master branch, this CI configuration will generate the demo page and publish it to the gh-pages branch.