Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T255429 New demo site #24

Merged
merged 4 commits into from
Jul 27, 2020
Merged

T255429 New demo site #24

merged 4 commits into from
Jul 27, 2020

Conversation

hueitan
Copy link
Member

@hueitan hueitan commented Jul 22, 2020

Phabricator Link : https://phabricator.wikimedia.org/T255429

Design has been confirmed by the designer

Dev please review the CI and webpack code changes, and don't be too picky on the demo code as it is modified from a static demo html

To preview this demo site, visit https://hueitan.github.io/sudhanshugautam3.github.io/

Mobile View (1) Mobile View (2)
Screen Shot 2020-07-22 at 15 15 31 Screen Shot 2020-07-22 at 15 15 38
Desktop View (1) Desktop View (2)
Screen Shot 2020-07-22 at 15 15 51 Screen Shot 2020-07-22 at 15 15 49

@hueitan hueitan requested review from stephanebisson and medied July 22, 2020 13:20
@medied
Copy link
Contributor

medied commented Jul 22, 2020

After the re-write the demo is now rendering much better across my devices (Chrome, Firefox in desktop and iphone), working lovely on mobile, good work Huei.

Some observations:

  • From the Phabricator ticket description I see this request: "Shows how Preview links are distinguished from other hyperlinks". Is this a good moment to add them?
  • Do we need to update README images? I guess that's not really necessary, they can serve as the memory of the first demo site
  • npm run build produces assets as expected
  • I can run locally on desktop and mobile as expected

demo/articles/english.html Outdated Show resolved Hide resolved
demo/articles/spanish.html Outdated Show resolved Hide resolved
demo/articles/spanish.html Outdated Show resolved Hide resolved
@hueitan
Copy link
Member Author

hueitan commented Jul 23, 2020

  • From the Phabricator ticket description I see this request: "Shows how Preview links are distinguished from other hyperlinks". Is this a good moment to add them?

As discussed with design, it currently shows different than the normal hyperlinks now, so we are safe here.

  • Do we need to update README images? I guess that's not really necessary, they can serve as the memory of the first demo site

It's not necessary here, we need to update the screenshot once the gallery is done for sure.

@medied
Copy link
Contributor

medied commented Jul 23, 2020

...we need to update the screenshot once the gallery is done for sure.

You're right. I suggest we update README with gallery screenshots once the licensing info is ready (so with this ticket)

@stephanebisson stephanebisson merged commit fc60955 into master Jul 27, 2020
@stephanebisson stephanebisson deleted the T255429-new-demo branch July 27, 2020 10:55
@stephanebisson stephanebisson restored the T255429-new-demo branch May 13, 2021 17:27
@stephanebisson stephanebisson deleted the T255429-new-demo branch May 13, 2021 17:32
@stephanebisson stephanebisson restored the T255429-new-demo branch July 28, 2022 12:56
@stephanebisson stephanebisson deleted the T255429-new-demo branch July 28, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants