-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T255429 New demo site #24
Conversation
After the re-write the demo is now rendering much better across my devices (Chrome, Firefox in desktop and iphone), working lovely on mobile, good work Huei. Some observations:
|
As discussed with design, it currently shows different than the normal hyperlinks now, so we are safe here.
It's not necessary here, we need to update the screenshot once the gallery is done for sure. |
You're right. I suggest we update README with gallery screenshots once the licensing info is ready (so with this ticket) |
Phabricator Link : https://phabricator.wikimedia.org/T255429
Design has been confirmed by the designer
Dev please review the CI and webpack code changes, and don't be too picky on the demo code as it is modified from a static demo html
To preview this demo site, visit https://hueitan.github.io/sudhanshugautam3.github.io/