Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T283081: Add browserslist-config-wikimedia #153

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Conversation

medied
Copy link
Contributor

@medied medied commented Oct 22, 2021

https://phabricator.wikimedia.org/T283081

What is the appropriate way to test this? Tested in Safari, Chrome and Firefox and no flags went up. This is what I get with npx browserslist

wikipedia-preview % npx browserslist
android 91
android 4.4.3-4.4.4
android 4.4
android 4.2-4.3
chrome 91
chrome 90
edge 91
edge 90
firefox 90
firefox 89
ie 11
ios_saf 14.5-14.7
ios_saf 14.0-14.4
ios_saf 13.4-13.7
ios_saf 13.3
ios_saf 13.2
ios_saf 13.0-13.1
ios_saf 12.2-12.4
ios_saf 12.0-12.1
ios_saf 11.3-11.4
ios_saf 11.0-11.2
ios_saf 10.3
ios_saf 10.0-10.2
ios_saf 9.3
ios_saf 9.0-9.2
opera 77
opera 76
safari 14.1
safari 14
safari 13.1
safari 13
safari 12.1
safari 12
safari 11.1
safari 11
safari 10.1
safari 10
safari 9.1
(node:16357) ExperimentalWarning: Conditional exports is an experimental feature. This feature could change at any time

Note this would be for the modern/grade A row: https://www.mediawiki.org/wiki/Compatibility#Browser_support_matrix

Copy link
Member

@hueitan hueitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,

question came up in package-lock file, i think we should keep lockfileVersion 2?
https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json#lockfileversion

@medied
Copy link
Contributor Author

medied commented Oct 26, 2021

Okay good call, updated package-lock.json

@stephanebisson stephanebisson merged commit b646ebd into main Oct 27, 2021
@stephanebisson stephanebisson deleted the T283081-browserslist branch October 27, 2021 13:05
@stephanebisson stephanebisson restored the T283081-browserslist branch July 28, 2022 12:56
@stephanebisson stephanebisson deleted the T283081-browserslist branch July 28, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants